Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppVeyor #854

Merged
merged 17 commits into from
Sep 7, 2021
Merged

AppVeyor #854

merged 17 commits into from
Sep 7, 2021

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jul 30, 2021 •
edited
Loading

Did you run make format && make check? Yes

Fixes #812

Changes:

  • Add .appveyor.yml file for AppVeyor CI service to test, build and release.

How to test this

  • For test and build, just make account on AppVeyor, make project for repo, and push commits.
  • For release, you should push a tag. You need add your <secure_code> in line 150 and line 113. To create that, first create Personal access tokens in Settings -> Developers Settings on GitHub setting. Then secure this token at your Account -> Encrypt YAML tab in your AppVeyor dashboard. [link].

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mrpalide
Copy link
Contributor Author

mrpalide commented Jul 30, 2021 •
edited
Loading

Some problems:

1. Latest go version for macos image on AppVeyor is 1.15, some build-in packages same as is/fs and embed available since v1.16 .
2. The windows related codes has some problem.

@mrpalide
Copy link
Contributor Author

mrpalide commented Aug 4, 2021 •
edited
Loading

Updates:

  • MacOS build now complete with installing go1.16 manually

Problems:

  • The Windows build get failed because of problems in related codes.
  • checksum.txt cannot create automaticaly by AppVeyor same as GoReleaser

Question:

  • I see multiple goarm variables on .goreleaser.yml, why use multiple goarm values, and which one is used in the build? I set GOARM=7.

@alexadhy
Copy link
Contributor

alexadhy commented Aug 5, 2021

Updates:

* MacOS build now complete with installing go1.16 manually

Problems:

* The Windows build get failed because of problems in related codes.

* `checksum.txt` cannot create automaticaly by **AppVeyor** same as **GoReleaser**

Question:

* I see multiple `goarm` variables on [`.goreleaser.yml`](https://github.com/skycoin/skywire/blob/aa0aa83b21d7b9e15c90d397c711e732980b52c6/.goreleaser.yml#L28), why use multiple `goarm` values, and which one is used in the build? I set `GOARM=7`.
  • windows build will have to wait for Feature/windows pty dmsg#93
  • goreleaser goarm, I think it's because we produce both ARMv7 and ARMv6 binaries, not sure why it's necessary.

@ersonp
Copy link
Contributor

ersonp commented Aug 5, 2021 •
edited
Loading

We need ARMv7 and ARMv6 binaries as we are supporting them in skybian (develop) here and here.

@mrpalide mrpalide changed the title [WIP] AppVeyor AppVeyor Aug 7, 2021
@jdknives
Copy link
Member

jdknives commented Aug 9, 2021

@mrpalide can you please make another commit to check if the integration runs?

@jdknives jdknives merged commit d79e72c into skycoin:develop Sep 7, 2021
@mrpalide mrpalide mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrpalide @CLAassistant @alexadhy @ersonp @jdknives